This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix all review memory leak on block transform #4428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +174 B (0%) Total Size: 979 kB
ℹ️ View Unchanged
|
ralucaStan
added
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
block: all reviews
Issues related to the All Reviews block.
labels
Jul 7, 2021
opr
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool fix, Raluca! Works well and the code seems fine to me 👏🏼
ralucaStan
added a commit
that referenced
this pull request
Jul 14, 2021
This reverts commit faf6294.
ralucaStan
added a commit
that referenced
this pull request
Jul 14, 2021
This reverts commit 2b9730a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: all reviews
Issues related to the All Reviews block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a memory leak when previewing transform options for the All reviews block.
The preview window was fetching the reviews, but the user could move away from the transform option before the ratings loaded and the preview was shown. This PR makes sure that the preview window is still opened before updating the state of the component with the new reviews.
Fixes #4304
How to test the changes in this Pull Request:
Changelog