This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Append SKU to name for SearchListControl #4366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +2 kB (0%) Total Size: 993 kB
ℹ️ View Unchanged
|
opr
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well! I am pre-approving on the basis that my comment is non-blocking and up to you if you want to fix it ✅
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Jun 17, 2021
Co-authored-by: Thomas Roberts <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some requests to allow SKUs to be searched in some of our product blocks.
SearchListControl
only allows searching by the given names, so to support this we can render the SKU appended to the name. This also makes it clearer what product is what when they are similarly named.Fixes #1098
Screenshots
How to test the changes in this Pull Request:
Changelog