This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix TwentyX styling issues for cart/checkout form fields #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
focus: global styles
mikejolley
changed the title
|
Size Change: +815 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Apr 12, 2021
Comment on lines
+84
to
+85
| .has-dark-controls | ||
| .wc-block-components-checkbox__input[type="checkbox"]:checked { |
There was a problem hiding this comment.
Was this auto-formatted? I think keeping each selector in one line makes code clearer.
Suggested change
| .has-dark-controls | |
| .wc-block-components-checkbox__input[type="checkbox"]:checked { | |
| .has-dark-controls .wc-block-components-checkbox__input[type="checkbox"]:checked { |
There was a problem hiding this comment.
Yeah, it looks like my IDE wrapped it due to length.
There was a problem hiding this comment.
Ok, let's merge it as-is. 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the styling issues raised in #3006.
The "Regular and Sale price are misaligned" issue was already solved.
Fixes #3006
Screenshots
Dark and light mode inputs:
How to test the changes in this Pull Request:
Changelog