Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Convert checkout context to data store - part 2 #6313

Closed
alexflorisca opened this issue Apr 25, 2022 · 1 comment · Fixed by #6455
Closed

Convert checkout context to data store - part 2 #6313

alexflorisca opened this issue Apr 25, 2022 · 1 comment · Fixed by #6455
Labels
block: checkout Issues related to the checkout block. status: stale Stale issues and PRs have had no updates for 60 days. type: refactor The issue/PR is related to refactoring.

Comments

@alexflorisca
Copy link
Member

Whilst working on moving the CheckoutState context into a data store, I came across an event emitter system that we are using only for the checkout. I was going to replace this with the new checkout data store as part of the Convert checkout context to data store PR, but I decided against it as it would be too big of a change, affecting critical parts of the block.

This issue is a continuation of the work done inside the PR mentioned above. More specifically, we'd need to

  • These types are very similar to the status state variable. See if we can use the same status and incorporate these in.
  • Replace event observers with selectors
  • Replace event emitters with actions
  • Move some of the logic in the checkout-state/index.ts into thunks within the checkout data store
@alexflorisca alexflorisca added type: refactor The issue/PR is related to refactoring. block: checkout Issues related to the checkout block. labels Apr 25, 2022
@alexflorisca alexflorisca changed the title Replace the checkout event emitter with the checkout data store Convert checkout context to data store - part 2 May 30, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 30, 2022
@github-actions github-actions bot closed this as completed Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. status: stale Stale issues and PRs have had no updates for 60 days. type: refactor The issue/PR is related to refactoring.
Projects
None yet
1 participant