Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PHP 8.1 #2411

Closed
diegocurbelo opened this issue Aug 15, 2022 · 4 comments · Fixed by #3357 or #3355
Closed

Compatibility with PHP 8.1 #2411

diegocurbelo opened this issue Aug 15, 2022 · 4 comments · Fixed by #3357 or #3355
Assignees
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@diegocurbelo
Copy link
Member

Add PHP 8.1 to the compatibility workflow matrix.

Make sure all flows work fine with PHP 8.1

@diegocurbelo diegocurbelo added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Aug 15, 2022
@stharvey
Copy link

Is there any news when this plugin will be compatible with PHP 8.1 ? Currently, the flow of connecting a Stripe account in the backend fails in PHP 8.1 but works with PHP 8.0.

PHP Fatal error: Uncaught TypeError: array_merge(): Argument #2 must be of type array, bool given in /home/xxxxx/public_html/shop/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php:111

Thanks

Simon

@diegocurbelo diegocurbelo added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Apr 11, 2024
@diegocurbelo diegocurbelo self-assigned this Apr 11, 2024
@RiaanKnoetze
Copy link
Contributor

@0yz
Copy link

0yz commented Aug 6, 2024

Still doesn't work.
When connecting to my Stripe account i get a fatal error on PHP 8.2 and 8.3.
Only after reverting to PHP version 7.4 i was able to connect my Stripe account.
This is an unacceptably urgent issue that needs to be fixed asap.

[06-Aug-2024 12:05:37 UTC] PHP Fatal error:  Uncaught TypeError: array_merge(): Argument #2 must be of type array, bool given in /var/www/website.xyz/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php:135
Stack trace:
#0 /var/www/website.xyz/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php(135): array_merge()
#1 /var/www/website.xyz/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php(87): WC_Stripe_Connect->save_stripe_keys()
#2 /var/www/website.xyz/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php(110): WC_Stripe_Connect->connect_oauth()
#3 /var/www/website.xyz/wp-includes/class-wp-hook.php(324): WC_Stripe_Connect->maybe_handle_redirect()
#4 /var/www/website.xyz/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#5 /var/www/website.xyz/wp-includes/plugin.php(517): WP_Hook->do_action()
#6 /var/www/website.xyz/wp-admin/admin.php(175): do_action()
#7 {main}
  thrown in /var/www/website.xyz/wp-content/plugins/woocommerce-gateway-stripe/includes/connect/class-wc-stripe-connect.php on line 135

@aheckler
Copy link
Contributor

aheckler commented Aug 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
6 participants