Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack to build JS for shortcode checkout #1584

Open
reykjalin opened this issue May 25, 2021 · 1 comment
Open

Use webpack to build JS for shortcode checkout #1584

reykjalin opened this issue May 25, 2021 · 1 comment
Labels
status: needs confirmation type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@reykjalin
Copy link
Contributor

We currently use uglify to build the shortcode version of the required JavaScript for customers to checkout with Stripe. Since #1467 we now have a webpack-based build system set up and ready to go so we should take advantage of that and migrate the shortcode checkout JS to the webpack-based build system.

This will entail moving the js from assets/js to client/shortcode. As part of this we'll want to re-use and add API calls to the client/api module — the goal is to re-use as much code as possible between the blocks and shortcode versions of the JS.

@reykjalin reykjalin added the type: technical debt This issue/PR represents/solves the technical debt of the project. label May 25, 2021
Copy link

Hi,
This issue has gone 150 days (5 months) without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest version, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs confirmation type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

No branches or pull requests

1 participant