Stripe Payment request button type not respected

[nerrad]

@senadir commented on Tue Nov 10 2020

Describe the bug

Payment request button type, an option that allows you to change the text or style of the payment request, is not being honoured on Cart and Checkout (even thou we pass the option to value from stripe settings).

To reproduce

Steps to reproduce the behavior:

1. In Stripe settings, change the option value to branded or custom.
   

2. See the button in the classic Cart block
   

3. In our block, it's not being respected
   

---

@mikejolley commented on Thu Nov 26 2020

I started to look at this and noticed these don't appear to be "official" types, certainly not mentioned in the docs here:
https://stripe.com/docs/stripe-js/elements/payment-request-button

I think the Stripe extension may be handling these custom types:
https://github.com/woocommerce/woocommerce-gateway-stripe/blob/27381ccf22b35afe3a81eb9c111a71b5fcbe3a6d/assets/js/stripe-payment-request.js

Not sure if we can mirror that or not.

---

@github-actions[bot] commented on Tue Jan 26 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

[nerrad]

I've copied this issue into this repo since it makes sense that any work on improving the existing blocks integration for Stripe is done here (now that the code is being migrated over).

[reykjalin]

I've added support for both the branded Google Pay button and Custom button in #1467 🙂

This will be fixed once #1467 is merged 🎉