This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add to Cart Form: Replace Notice with Skeleton component #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +234 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
thealexandrelara
changed the title
gigitux
suggested changes
Mar 26, 2023
I think we have a limitation to do that, because the block wrapper disables some mouse events, so if we put a popover inside the block wrapper it wouldn't trigger the mouseover event. In that case, we could put it around the block wrapper, but I don't know if it would be the best solution, what do you think? |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
…ocks into feat/replace-notice-with-skeleton-on-add-to-cart-form-block
gigitux
removed
the
status: stale
|
Hey, @thealexandrelara, I added the tooltip and also updated the class names on the editor site to follow the CSS guidelines via 41c2aa7. |
Looking great, thank you! Just a question regarding the Tooltip position, on the image you shared the tooltip appears at the top, but in the current implementation it is appearing at the bottom, is that expected? |
Good observation! If we put the tooltip on the top, it will be on top of the quick controls, for this reason, I preferred to move it at the bottom! |
Great! I agree with the change, if it's okay to you, we can approve this PR and merge it |
|
I added the different cursor style as design specs via 3c4a05b. |
thealexandrelara
deleted the
feat/replace-notice-with-skeleton-on-add-to-cart-form-block
branch
opr
added
type: enhancement
|
@thealexandrelara I have added the correct labels to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Notice component of the Add To Cart Form block with a Skeleton component
Fixes #8818
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
wp-groupsection with thewp-groupsection inside the templates/templates/blockified/single-product.html file of this PR.WooCommerce Visibility
Changelog