This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove unnecessary filter by price label style #6994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
|
albarin
force-pushed
the
fix/price-selector-style
branch
from
August 25, 2022 16:59
1f1c998
to
e7b5d51
Compare
albarin
changed the title
Fix the price filter setting label style
Remove unnecessary filter by price label style
Aug 25, 2022
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
August 25, 2022 17:00
Size Change: -16 B (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
sunyatasattva
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as discussed on Slack.
tarhi-saad
added
skip-changelog
PRs that you don't want to appear in the changelog.
and removed
status: ready to merge
labels
Aug 29, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uppercase style was too generic and was affecting other labels.
Note: labels will be uppercase in the feature because of this change in Gutenberg. We are removing this style to avoid the side-effect that it was causing.
User Facing Testing
Price Range Selector
label is not uppercase.Columns
label is not uppercase.WooCommerce Visibility