Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Mini-Cart Contents block is not scrollable in Site View, even though a scrollbar is visible #9439

Closed
Tracked by #9198
Aljullu opened this issue May 11, 2023 · 7 comments
Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 11, 2023

Issue initially reported by @annezazu in peapX7-2k4-p2#comment-2855.

To reproduce

  1. Go to Appearance > Editor > Template Parts > Mini Cart.
  2. Notice there is a scroll bar inside the Mini Cart Contents block but it's not scrollable. That might be confusing for users.

imatge

Expected behavior

We should either:

  1. Hide the scrollbar so it's clear that the Mini Cart Contents block is not scrollable.
  2. Allow users to scroll it.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: mini-cart Issues related to the Mini-Cart block. labels May 11, 2023
@roykho
Copy link
Member

roykho commented Jun 1, 2023

I am not able to reproduce this can you please confirm again:
KyxU58.gif

  • WP 6.2.2
  • Gutenberg 15.9.0
  • Woo Blocks trunk

@Aljullu
Copy link
Contributor Author

Aljullu commented Jun 1, 2023

I am not able to reproduce this can you please confirm again:

Your screenshot is after you fully opened the template part. However, the issue refers to the Site View, in other words, when the left sidebar is still open. There is a video in peapX7-2k4-p2#comment-2855 which might help see the issue (starting from 1:00).

@roykho
Copy link
Member

roykho commented Jun 1, 2023

I see what you mean now. However I personally don't think that is an issue. None of the "preview" is interactive. With the scrollbar showing, it lets user know that they can add more blocks after the cart items and it also shows how it functions when there are more items to display.

@danieldudzic
Copy link
Contributor

I see what you mean now. However I personally don't think that is an issue. None of the "preview" is interactive. With the scrollbar showing, it lets user know that they can add more blocks after the cart items and it also shows how it functions when there are more items to display.

I agree with @roykho. I don't think having a (non-functional) scrollbar present is a deal breaker - it's just a more or less accurate "preview" of the Mini Cart when it has multiple items. Not sure it has to match 1 to 1 the frontend view.

@Aljullu
Copy link
Contributor Author

Aljullu commented Jun 1, 2023

Right, I don't have a strong opinion either. @annezazu what do you think?

@annezazu
Copy link

annezazu commented Jun 1, 2023

I'm not quite sure it's communicating that "they can add more blocks after the cart items and it also shows how it functions when there are more items to display" fwiw but this isn't a dealbreaker for me. Feel free to close if it's not something to pursue.

@Aljullu
Copy link
Contributor Author

Aljullu commented Jun 12, 2023

Based on the discussion, I'm going to close this issue. We can always reopen or create a new one if we get more reports of this.

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants