Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

'Mini-Cart in cart and checkout pages' toggle is visible when adding the Mini Cart to a post or page #9428

Closed
Tracked by #9198
Aljullu opened this issue May 10, 2023 · 0 comments · Fixed by #9442
Closed
Tracked by #9198

'Mini-Cart in cart and checkout pages' toggle is visible when adding the Mini Cart to a post or page #9428

Aljullu opened this issue May 10, 2023 · 0 comments · Fixed by #9442
Assignees
@Aljullu
Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented May 10, 2023

To reproduce

  1. Create a post or page.
  2. Add the Mini Cart block and select it.
  3. Notice in the sidebar there is the Mini-Cart in cart and checkout pages toggle.
    imatge

Expected behavior

That toggle should only be available in the Site Editor, but not in the post/page editor.

Additional context

For some reason, isSiteEditor in this line seems to be true when in the post/page editor.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: mini-cart Issues related to the Mini-Cart block. labels May 10, 2023
This was referenced May 10, 2023
Closed
Merged
@Aljullu Aljullu self-assigned this May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
1 participant
@Aljullu