Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Ensure Cart block supports the WCBlock-level global styles for Blocks » Product Title » Layout #8830

Closed
Tracked by #8710
tarunvijwani opened this issue Mar 23, 2023 · 3 comments
Assignees
Labels
block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.

Comments

@tarunvijwani
Copy link

tarunvijwani commented Mar 23, 2023

Currently, the Cart block partially supports the default WCBlock-level global styles for Blocks » Product Title » Layout. This issue aims to ensure that the Cart block fully supports the default WCBlock-level global styles.

Steps to reproduce

  1. Go to WP Admin » Apperance » Editor.
  2. Open the Styles sidebar.
  3. Open the Blocks » Product Title » Layout settings.
  4. Adjust the settings.
  5. Notice it is getting reflected properly on the front end and editor.

Screenshots

Settings Editor Frontend
image image image
@tarunvijwani tarunvijwani added type: enhancement The issue is a request for an enhancement. block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure. labels Mar 23, 2023
@tarunvijwani tarunvijwani self-assigned this Mar 23, 2023
@tarunvijwani tarunvijwani changed the title Ensure Cart block supports the theme-level global styles for Blocks » Product Title » Layout Ensure Cart block supports the WCBlock-level global styles for Blocks » Product Title » Layout Apr 3, 2023
@tarunvijwani
Copy link
Author

We're not changing the semantics of the product title present in the cart-line items. Details are available here: pdFofs-SY-p2#comment-914

@nielslange nielslange assigned nielslange and unassigned tarunvijwani Apr 5, 2023
@tarunvijwani
Copy link
Author

We're discussing the final approach on slack: p1681203933835379-slack-C02UBB1EPEF

@tarunvijwani
Copy link
Author

Closing the issue as per the discussion on Slack: p1681728763577949/1681203933.835379-slack-C02UBB1EPEF

The Product Title block and Product Title component in the Cart Line Items block are different; hence they should have different global style options. The Product Title component should inherit the parent's Global styles, i.e., Cart Line Items inner block instead of the Product Title block.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants