Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Display the link to add the shipping address when the "No location by default" is enabled #8027

Closed
tarunvijwani opened this issue Dec 23, 2022 · 4 comments · Fixed by #8141
Closed
Assignees
Labels
block: cart Issues related to the cart block. focus: settings Issues related to managing settings (including wc-settings). type: enhancement The issue is a request for an enhancement.

Comments

@tarunvijwani
Copy link

tarunvijwani commented Dec 23, 2022

There is a setting in WooCommerce to set the default customer location. The Cart block won't show any address if there is no default value.
We need to display the link to add the shipping address when the "No location by default" is enabled:

image

Screenshots

Actual Expected
image image

Slack

p1671541330197299-slack-C8X6Q7XQU

@tarunvijwani tarunvijwani added type: enhancement The issue is a request for an enhancement. block: cart Issues related to the cart block. labels Dec 23, 2022
@ralucaStan ralucaStan added the focus: settings Issues related to managing settings (including wc-settings). label Dec 30, 2022
@ralucaStan
Copy link
Contributor

@tarunvijwani what do you mean by default value in The Cart block won't show any address if there is no default value.
Also, it might be helpful to explain the behavior in the shortcode cart to better understand the issue and the expected result

@tarunvijwani
Copy link
Author

In the recent conversation with @elizaan36, we decided to show "Add an address" link to make it more consistent with the "Add a coupon" link.

what do you mean by default value in The Cart block won't show any address if there is no default value.

If a guest user didn't add any address anywhere, it would simply show the change address link. However, the recent design shared by @elizaan36 for the coupon code had the text "Add an address for shipping rates" for it. So we created this ticket to implement it.

Also, it might be helpful to explain the behavior in the shortcode cart to better understand the issue and the expected result

On the cart shortcode page, the text is "Calculate shipping". However, this is an enhancement, not a bug. We want to make it more consistent with the coupon code link.

image

@ralucaStan
Copy link
Contributor

@elizaan36 I think the purple link should in fact inherit from the theme the anchor color. Is that the expected result?

@elizaan36
Copy link

That's correct, that would be the accent color for the theme.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: settings Issues related to managing settings (including wc-settings). type: enhancement The issue is a request for an enhancement.
Projects
None yet
3 participants