Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

ExperimentalOrderShippingPackages slot is missing in the editor preview #7939

Closed
MonteLogic opened this issue Dec 14, 2022 · 5 comments · Fixed by #8111
Closed

ExperimentalOrderShippingPackages slot is missing in the editor preview #7939

MonteLogic opened this issue Dec 14, 2022 · 5 comments · Fixed by #8111
Labels
focus: documentation This issue is a request for better documentation. type: bug The issue/PR concerns a confirmed bug.

Comments

@MonteLogic
Copy link

MonteLogic commented Dec 14, 2022

How would I use the Slot Fill on the edit page to make it show up exactly where it would be on the checkout page?

For instance, my app on the checkout page looks like this:
image

While on my edit page I cannot access the area that's in the same are to put information/data in it. It looks as follows:
image

What steps do I need to take to duplicate the app view on edit and checkout page for better user workflow?

I have already setup the IntegrationInterface to work well as well as properly link to the edit file which it is compiled to.

If this is not possible what solutions could make it close to the area?

Thanks in advance.

@MonteLogic MonteLogic added the focus: documentation This issue is a request for better documentation. label Dec 14, 2022
@mikejolley
Copy link
Member

Are you using slot fills for the frontend view? If so, can you share how you've done it. AFAIK slot fills work under both contexts.

@MonteLogic
Copy link
Author

MonteLogic commented Dec 14, 2022

Yes, I am using SlotFills for the frontend view. The project I am working on is a fork of woocommerce/newsletter-test

Gist with edit.js, block.js and IntegrationInterface.
https://gist.github.com/795257bccc733ff6d35a6ec74668f187

@mikejolley
Copy link
Member

Ah ExperimentalOrderShippingPackages. @senadir this one is not shown in the editor. is there a reason for this?

{ isEditor ? (
<Packages
packages={ shippingRates }
noResultsMessage={ noResultsMessage }
renderOption={ renderOption }
/>
) : (
<>
<ExperimentalOrderShippingPackages.Slot
{ ...slotFillProps }
/>
<ExperimentalOrderShippingPackages>
<Packages
packages={ shippingRates }
noResultsMessage={ noResultsMessage }
renderOption={ renderOption }
/>
</ExperimentalOrderShippingPackages>
</>
) }

@senadir
Copy link
Member

senadir commented Dec 19, 2022

We possibly missed this one, I can't think of a reason to skip it there.

@mikejolley mikejolley added the type: bug The issue/PR concerns a confirmed bug. label Dec 19, 2022
@ralucaStan ralucaStan changed the title Feedback on ./docs/third-party-developers/extensibility/checkout-block/slot-fills.md ExperimentalOrderShippingPackages slot is missing in the editor preview Dec 30, 2022
@opr
Copy link
Contributor

opr commented Jan 4, 2023

It looks like no fills are being rendered in the editor, the slot is there but nothing fills it.

Trying to remove the isEditor check here results in an empty space below "Shipping options"

I'll continue investigating this but if anyone has any ideas why the fill won't render please let me know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: documentation This issue is a request for better documentation. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants