Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

WooCommerce Essential Header | Light pattern doesn't inherit the styles from the theme #7523

Closed
gigitux opened this issue Oct 28, 2022 · 2 comments
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@gigitux
Copy link
Contributor

gigitux commented Oct 28, 2022

Describe the bug

WooCommerce Essential Header | Light pattern doesn't inherit the global styles.

Steps to reproduce the behavior:

  1. Enable TT3 theme.
  2. Go to Appearance > Site Editor
  3. Use the Aubergine style variation
  4. Replace the header with WooCommerce Essential Header | Light
  5. Check that the text is black and doesn't look well with the style variation.

Expected behavior

The pattern should inherit the styles from the theme.

Screenshots

Screen Capture on 2022-10-28 at 11-19-57

We should either:

  1. Not define a font color and inherit it from the parent elements.
  2. Define a font color and background color, so we can ensure there is enough contrast between the text and the background.
@Aljullu
Copy link
Contributor

Aljullu commented Oct 28, 2022

Oh, it looks like there was already an issue in WC core repo: woocommerce/woocommerce#35248 and there is an open PR fixing it: #7524.

@gigitux
Copy link
Contributor Author

gigitux commented Oct 28, 2022

Oh, great! I'm closing this issue as a duplicate of #7524.

@gigitux gigitux closed this as completed Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants