Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Dark mode or color controls on Price Slider? #7202

Closed
vivialice opened this issue Sep 22, 2022 · 2 comments
Closed

Dark mode or color controls on Price Slider? #7202

vivialice opened this issue Sep 22, 2022 · 2 comments
Labels
block: filter by price Issues related to the Filter by Price block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.

Comments

@vivialice
Copy link

I was testing out my site with different style presets and noticed the price filter slider is still black. Could we pic up a different color from the theme styles, apply a dark mode, or prioritise setting controls? Ideally, it would swap out on its own when choosing a new theme style.

Screenshot 2022-09-22 at 12 06 21

For example, the mini cart picked up this accent color to work with the theme's dark backgound:
Screenshot 2022-09-22 at 12 08 58

@vivialice vivialice added the block: filter by price Issues related to the Filter by Price block. label Sep 22, 2022
@senadir
Copy link
Member

senadir commented Sep 22, 2022

Cart/Checkout has a dark mode toggle, it would be nice to:

  • Continue using that pattern.
  • Switch to something that plays well directly with Global Styles.

@danielwrobert danielwrobert added type: bug The issue/PR concerns a confirmed bug. focus: global styles Issues that involve styles/css/layout structure. labels Sep 22, 2022
@Aljullu
Copy link
Contributor

Aljullu commented Oct 27, 2022

Closing because it seems to be a duplicate of #7130. Using CSS's currentColor seems a simpler approach than adding global styles specific to the range or adding a dark mode toggle IMO.

@Aljullu Aljullu closed this as completed Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: filter by price Issues related to the Filter by Price block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants