Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Mini cart badge has undefined as a classname #6977

Closed
Tracked by #8556
senadir opened this issue Aug 24, 2022 · 1 comment · Fixed by #8557
Closed
Tracked by #8556

Mini cart badge has undefined as a classname #6977

senadir opened this issue Aug 24, 2022 · 1 comment · Fixed by #8557
Assignees
@albarin
Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@senadir
Copy link
Member

senadir commented Aug 24, 2022

In #5985 support for colorClassNames and style was removed from the mini cart badge but those attributes weren't removed, this results in having undefined as an attribute.

Fix:
Remove those attributes.

Future consideration:
use classnames to remove unused classes.
@senadir senadir added type: bug The issue/PR concerns a confirmed bug. block: mini-cart Issues related to the Mini-Cart block. labels Aug 24, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 24, 2022
@Aljullu Aljullu added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Feb 27, 2023
@Aljullu Aljullu mentioned this issue Feb 27, 2023
Closed
@albarin albarin self-assigned this Feb 27, 2023
@albarin albarin mentioned this issue Feb 27, 2023
Merged
3 tasks
@Aljullu Aljullu removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@albarin albarin

Labels
block: mini-cart Issues related to the Mini-Cart block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove colorClassName and style from QuantityBadge woocommerce/woocommerce-blocks
3 participants
@albarin @Aljullu @senadir