Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove Relative File Paths for style-attributes Imports #6866

Closed
danielwrobert opened this issue Aug 5, 2022 · 0 comments · Fixed by #6870
Closed

Remove Relative File Paths for style-attributes Imports #6866

danielwrobert opened this issue Aug 5, 2022 · 0 comments · Fixed by #6870
Assignees
Labels
type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.

Comments

@danielwrobert
Copy link
Contributor

We want to try avoiding relative paths as much as possible, unless the imports specifically belong together.

For the style-attributes imports (e.g., import { useTypographyProps } from '../../hooks/style-attributes';), there is a @woocommerce/base-hooks alias that can be used.

The hook will need to be moved into the directory that houses our other hooks. With that, we'll want to ensure that this change does not have any unintended impact on any other scripts that rely on the current location (and make the proper adjustments where needed).

See this conversation for context.

@danielwrobert danielwrobert added type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. labels Aug 5, 2022
@danielwrobert danielwrobert self-assigned this Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant