Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Elements API: complete an audit of all blocks that make use of core elements and update them to inherit Elements API styles #6567

Closed
frontdevde opened this issue Jun 14, 2022 · 2 comments
Closed

Elements API: complete an audit of all blocks that make use of core elements and update them to inherit Elements API styles #6567

frontdevde opened this issue Jun 14, 2022 · 2 comments
Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.

Comments

@frontdevde
Copy link
Contributor

frontdevde commented Jun 14, 2022 •
edited
Loading

For context and details see p2-pdnLyh-1kY.
@frontdevde frontdevde added the focus: FSE Work related to prepare WooCommerce for FSE. label Jun 14, 2022
@colorful-tones
Copy link
Member

colorful-tones commented Jul 25, 2022 •
edited
Loading

@frontdevde I'm not sure if this is related or worthy of a separate issue. Gutenberg is currently working towards including button and a styling in theme.json. In support of this there was this bit of CSS recently introduced to target a:not(.wp-element-buttons) with styling. However, it seems that most WooCommerce Blocks blocks do not have this .wp-element-button class. Therefore, their output is unaffected by this update.

Screen Shot 2022-07-25 at 4 37 38 PM

Screen Shot 2022-07-25 at 4 35 07 PM

This was referenced Aug 23, 2022
Closed
Closed
Closed
@Aljullu Aljullu changed the title Elements API: complete an audit of all blocks that make use of core blocks and see if Element API styles apply as expected across the board. Elements API: complete an audit of all blocks that make use of core elements and update them to inherit Elements API styles Aug 23, 2022
@Aljullu Aljullu mentioned this issue Aug 23, 2022
Closed
@Aljullu Aljullu added type: enhancement The issue is a request for an enhancement. focus: global styles Issues that involve styles/css/layout structure. labels Aug 23, 2022
@Aljullu
Copy link
Contributor

Aljullu commented Nov 7, 2022

I'm going to close this issue. Regarding buttons, it has been mostly fixed in #7516. As the Elements API evolves, we will consider more opportunities to use it in our blocks, but I don't think we have anything actionable here right now.

@Aljullu Aljullu closed this as completed Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: global styles Issues that involve styles/css/layout structure. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colorful-tones @frontdevde @Aljullu