Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove duplicated title and description from filter blocks #6543

Closed
dinhtungdu opened this issue Jun 9, 2022 · 1 comment · Fixed by #6978
Closed

Remove duplicated title and description from filter blocks #6543

dinhtungdu opened this issue Jun 9, 2022 · 1 comment · Fixed by #6978
Labels
block-type: filter blocks Issues related to all of the filter blocks. focus: i18n The issue/PR is related to internationalization. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@dinhtungdu
Copy link
Member

Is your feature request related to a problem? Please describe.

In #6505, we decided to keep the title and description of filter blocks in both index and metadata files to keep the translation for those fields working as expected during the transition phase. Once the new language packs have been updated, we should remove the title and description from the index file.

Describe the solution you'd like

We should remove duplicated strings after the version of WC Blocks containing refactored filter blocks is merged into the WC core.
@dinhtungdu dinhtungdu added type: enhancement The issue is a request for an enhancement. focus: i18n The issue/PR is related to internationalization. block-type: filter blocks Issues related to all of the filter blocks. labels Jun 9, 2022
@dinhtungdu dinhtungdu mentioned this issue Jun 9, 2022
Merged
14 tasks
@Aljullu Aljullu added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Jun 9, 2022
@dinhtungdu
Copy link
Member Author

WC 6.7.0 check-in. The blocks.json changes for filters block haven't merged into WC core yet. The WooCommerce Blocks version shipped with WC 6.7.0 is 7.8.3, while the change in #6505 was released in 7.9.0.

@Aljullu Aljullu added the type: cooldown Things that are queued for a cooldown period (assists with planning). label Aug 18, 2022
@Aljullu Aljullu mentioned this issue Sep 21, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block-type: filter blocks Issues related to all of the filter blocks. focus: i18n The issue/PR is related to internationalization. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert filter blocks to inner blocks woocommerce/woocommerce-blocks
2 participants
@Aljullu @dinhtungdu