Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Not all Cart & Checkout inner blocks render when migrating to inner blocks for Order Summary #6185

Closed
ralucaStan opened this issue Apr 4, 2022 · 1 comment · Fixed by #6195
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug.

Comments

@ralucaStan
Copy link
Contributor

ralucaStan commented Apr 4, 2022

Describe the bug

When migrating to the Cart & Checkout blocks that have Order summary with inner blocks not all content is loaded for the Order summary.

See internal conversation p1649074270986619/1649068099.800419-slack-C8X6Q7XQU

To reproduce

Steps to reproduce the behaviour:

  1. Go to version v7.2.0
  2. Build and add C & C blocks to pages
  3. Check to see the content
  4. Go to git checkout trunk
  5. Build and see that some inner blocks are missing as follows:
    Cart
  • Order summary heading, Coupons & Taxes(?) inner blocks
    Checkout
  • Cart summary, Coupons & Taxes(?) inner blocks

Screenshots

Expected behavior

All inner blocks should be rendered in the Order summary.

@ralucaStan ralucaStan added type: bug The issue/PR concerns a confirmed bug. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Apr 4, 2022
@ralucaStan ralucaStan self-assigned this Apr 4, 2022
@senadir senadir added the status: blocker Used on issues or pulls that block work from being released. label Apr 5, 2022
@senadir
Copy link
Member

senadir commented Apr 5, 2022

This would only apply to non forced blocks, other blocks which have lock.remove: true would show up fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
2 participants