Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Replace ToggleButtonControl with ToggleGroupControl #5873

Closed
Aljullu opened this issue Feb 17, 2022 · 0 comments · Fixed by #5967
Closed

Replace ToggleButtonControl with ToggleGroupControl #5873

Aljullu opened this issue Feb 17, 2022 · 0 comments · Fixed by #5967
Assignees
@danieldudzic
Labels
focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Feb 17, 2022

WC Blocks has a custom component named ToggleButtonControl which generates this kind of UI:

ToggleButtonControl screenshot

That's very similar to Gutenberg's ToggleGroupControl:

ToggleGroupControl screenshot

This issue is about completely replacing all instances of ToggleButtonControl with ToggleGroupControl. This way we will more closely follow Gutenberg UI's and we won't need to maintain this specific component.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Feb 17, 2022
@danieldudzic danieldudzic mentioned this issue Mar 1, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danieldudzic danieldudzic

Labels
focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the ToggleButtonControl in favor of ToggleGroupControl woocommerce/woocommerce-blocks
2 participants
@danieldudzic @Aljullu