archive-product block template doesn't correctly show its title

[sunyatasattva]

Describe the bug

The slug archive-product does not get parsed into the correct human readable title.

To reproduce

Steps to reproduce the behavior:

1. Go to Appearance → Editor → Browse all templates
2. Make sure you have archive-product.html in your theme's templates directory
3. Notice how the slug is not parsed into a title

Expected behavior

Slug should read "Product archive" if language is set to English.

Screenshots

[Aljullu]

@sunyatasattva I thought that was expected if the theme doesn't define the template under templates in theme.json. Is it only happening for archive-product or for any other WC template?

[sunyatasattva]

@Aljullu Perhaps I'm wrong, but I think this is actually a bug in the way the strings are parsed, and I also might know where it stems from. This only happens for archive-product and, as you can see, the Product Category and Product Tag are correctly named (even though in the example above, they do not exist and are actually using the archive-product fallback).

Again, I might be wrong, but what would be the intent of leaving archive-product as a slug? I think I might have actually introduced this bug myself 😬

[tjcafferkey]

I think this is expected behaviour, it may seem to work for Product Category and Product Tag because of a side-effect of us duplicating the themes archive-product.html for those templates somehow.

If you add a single-product.html file to the theme without defining it in theme.json you get the same result.

Still if we are able to fix it I don't see why not, however we need to be aware that if a title is defined in the themes theme.json that should superseed our naming convention.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.