Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Featured Product Block Search is Broken #4983

Closed
mikejolley opened this issue Oct 22, 2021 · 1 comment · Fixed by #5156
Closed

Featured Product Block Search is Broken #4983

mikejolley opened this issue Oct 22, 2021 · 1 comment · Fixed by #5156
Assignees
Labels
block: featured product Issues related to the Featured Product block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@mikejolley
Copy link
Member

Describe the bug

On a store with a large number (+100) products, search appears to be broken when using the Featured Product Block. On a smaller catalog you can simulate this by editing the values in:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/5f34c86072936ac908a93c49881775d21df69a6a/assets/js/editor-components/utils/index.js#L19

To reproduce

Steps to reproduce the behaviour:

  1. Have a large catalog, or edit the function above so it does requests to the API
  2. Insert Featured Product Block
  3. Enter a search term for a product not visible in the list
  4. No results. Query has search=& in it.

Expected behaviour

It should do the query and return the filtered results.

This was reported here: https://wordpress.org/support/topic/feature-product-not-wordking-correcly/ I reproduced it locally.

@mikejolley mikejolley added the type: bug The issue/PR concerns a confirmed bug. label Oct 22, 2021
@notdian
Copy link

notdian commented Oct 25, 2021

Maybe related 10up/ElasticPress#2371

@nerrad nerrad added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: featured product Issues related to the Featured Product block. labels Oct 27, 2021
@alexflorisca alexflorisca self-assigned this Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: featured product Issues related to the Featured Product block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants