Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Cart i2: Add empty cart default inner blocks #4793

Closed
senadir opened this issue Sep 21, 2021 · 1 comment · Fixed by #4976
Closed

Cart i2: Add empty cart default inner blocks #4793

senadir opened this issue Sep 21, 2021 · 1 comment · Fixed by #4976
Assignees
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@senadir
Copy link
Member

senadir commented Sep 21, 2021

Empty Cart view is currently broken in Cart i2, so we removed it. We should add it back and make sure it works the same way as Cart i1:

  • Toggling it would unmount Full Cart blocks and their selection.
  • The value persist (going to be hard to have to innerBlocks on the same level).
@senadir
Copy link
Member Author

senadir commented Oct 19, 2021

As of now, those points are fixed:

Toggling it would unmount Full Cart blocks and their selection.
The value persist (going to be hard to have to innerBlocks on the same level).

What's left is adding the default empty cart inner block layout.

@senadir senadir changed the title Cart i2: Handle Empty cart view in the editor Cart i2: Add empty cart default inner blocks Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants