Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove custom shipping_phone handling (requires WC 5.6+) #4493

Closed
github-actions bot opened this issue Jul 22, 2021 · 7 comments · Fixed by #5326
Closed

Remove custom shipping_phone handling (requires WC 5.6+) #4493

github-actions bot opened this issue Jul 22, 2021 · 7 comments · Fixed by #5326
Labels
block: cart Issues related to the cart block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2021

Remove custom shipping_phone handling (requires WC 5.6+)

set_shipping_phone was added in 5.6 https://woocommerce.github.io/code-reference/classes/WC-Order.html#method_set_shipping_phone
This comment was added before 5.6 got released.
Now we're on 6.8 we can remove the code that handles pre-5.6 WC


https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/2bfe6deda4ef3f94972466290b3d7484e13c3182/src/StoreApi/Routes/CartUpdateCustomer.php#L123-L132

🚀 This issue was generated by the automations bot based on a todo comment in 2bfe6de when #4268 was merged. cc @mikejolley
@mikejolley mikejolley added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Jul 22, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 22, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 22, 2021
@mikejolley mikejolley removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 22, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jan 22, 2022
@github-actions github-actions bot closed this as completed Feb 1, 2022
@Aljullu Aljullu added the block: cart Issues related to the cart block. label Aug 23, 2022
@Aljullu
Copy link
Contributor

Aljullu commented Aug 23, 2022

@ralucaStan maybe this one needs to be re-opened?

@ralucaStan ralucaStan removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 24, 2022
@ralucaStan ralucaStan reopened this Aug 24, 2022
@ralucaStan
Copy link
Contributor

Thank you @Aljullu, I've reopened it.

@ralucaStan ralucaStan added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Aug 24, 2022
@masteradhoc
Copy link
Contributor

@ralucaStan is it possible this was already fixed by #5326 ?

@ralucaStan
Copy link
Contributor

Nice catch @masteradhoc! ✋
Closing the ticket, the legacy set_shipping_phone was removed in #5326

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants