Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

these styles replace the need for SidebarLayout styles. W... #4491

Closed
github-actions bot opened this issue Jul 22, 2021 · 2 comments · Fixed by #4745
Closed

these styles replace the need for SidebarLayout styles. W... #4491

github-actions bot opened this issue Jul 22, 2021 · 2 comments · Fixed by #4745
Assignees
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure.

Comments

@github-actions
Copy link
Contributor

these styles replace the need for SidebarLayout styles. We define styles here so placeholder elements (loading state) for the checkout has the same sidebar type layout before JS loads.


https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/2bfe6deda4ef3f94972466290b3d7484e13c3182/assets/js/blocks/cart-checkout/checkout-i2/styles/style.scss#L32-L43

🚀 This issue was generated by the automations bot based on a todo comment in 2bfe6de when #4268 was merged. cc @mikejolley
@mikejolley mikejolley added the block: checkout Issues related to the checkout block. label Jul 22, 2021
@mikejolley
Copy link
Member

We need to do a full review over styles for checkout i2 since some need moving to the parent block level.

@mikejolley mikejolley added the focus: global styles Issues that involve styles/css/layout structure. label Aug 13, 2021
@mikejolley mikejolley self-assigned this Sep 2, 2021
@mikejolley
Copy link
Member

This issue mostly concerns the fact that many of the styles in i2 still inherit from i1. We should review the styles and consolidate them when we replace checkout i1 with checkout i2. I've asked Darren when he thinks we'll be able to do this, so let's move this to sprint 2 until a decision is made.

@mikejolley mikejolley removed their assignment Sep 2, 2021
@mikejolley mikejolley self-assigned this Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant