Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Express payment buttons unmounts and mount again on changes causing layout shift #4383

Closed
senadir opened this issue Jun 22, 2021 · 5 comments
Closed

Express payment buttons unmounts and mount again on changes causing layout shift #4383

senadir opened this issue Jun 22, 2021 · 5 comments
Labels
block: checkout Issues related to the checkout block. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug.

Comments

@senadir
Copy link
Member

senadir commented Jun 22, 2021

Describe the bug

A clear and concise description of what the bug is.

To reproduce

You need to have an express payment method set up.

  1. Go to checkout.
  2. Change something in the checkout like email, shipping address, or selecting a different shipping method.
  3. Notice that express payment buttons would unmount and mount again.

I confirmed that this only happens for express payment methods. Regular payment methods are fine.

This issue also predates #4228 I tested with 5.3.1 and the issue was there as well.

Expected behaviour

Buttons shouldn't unmount and mount. If they're no longer valid, they should unmount completely.

Screenshots

jumping.mov
@senadir senadir added type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. labels Jun 22, 2021
@senadir
Copy link
Member Author

senadir commented Jun 22, 2021

Content jumping around is called cumulative layout shift and is harmful to the website SEO and just straight out annoying.
https://web.dev/cls/

@ralucaStan
Copy link
Contributor

Possibly related to #4321

@senadir
Copy link
Member Author

senadir commented Jul 7, 2021

Yes, same issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 6, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: checkout Issues related to the checkout block. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nerrad @ralucaStan @senadir