Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Payment method content could potentially become a bottlen... #4359

Closed
github-actions bot opened this issue Jun 16, 2021 · 5 comments
Closed

Payment method content could potentially become a bottlen... #4359

github-actions bot opened this issue Jun 16, 2021 · 5 comments
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. focus: performance The issue/PR is related to performance. status: stale Stale issues and PRs have had no updates for 60 days.

Comments

@github-actions
Copy link
Contributor

Find a way to Memoize Express Payment Method Content

Payment method content could potentially become a bottleneck if lots of logic is ran in the content component. ItCurrently re-renders excessively but is not easy to useMemo because paymentMethodInterface could become stale.paymentMethodInterface itself also updates on most renders.

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/a8c49055cddf06bf183df1c67ba7bcd7cdb757e1/assets/js/blocks/cart-checkout/payment-methods/express-payment-methods.js#L114-L129

🚀 This issue was generated by the automations bot based on a todo comment in a8c4905 when #4228 was merged. cc @mikejolley
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 16, 2021
@nerrad nerrad added category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. focus: performance The issue/PR is related to performance. block: checkout Issues related to the checkout block. block: cart Issues related to the cart block. and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Aug 18, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 18, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 20, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 20, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 23, 2021
@github-actions
Copy link
Contributor Author

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 22, 2022
@github-actions github-actions bot closed this as completed Mar 4, 2022
@mikejolley mikejolley removed the status: stale Stale issues and PRs have had no updates for 60 days. label Mar 4, 2022
@mikejolley mikejolley reopened this Mar 4, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented May 5, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. focus: performance The issue/PR is related to performance. status: stale Stale issues and PRs have had no updates for 60 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejolley @nerrad