Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

"Sale" Not Being Translated on the All Products Block #4019

Closed
igotdes opened this issue Mar 31, 2021 · 0 comments · Fixed by #4897
Closed

"Sale" Not Being Translated on the All Products Block #4019

igotdes opened this issue Mar 31, 2021 · 0 comments · Fixed by #4897
Assignees
Labels
focus: i18n The issue/PR is related to internationalization. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug.

Comments

@igotdes
Copy link

igotdes commented Mar 31, 2021

Describe the bug

When using the All Products block, "Sale" is translated while editing a page. However, on the front end, it's not.

To reproduce

Steps to reproduce the behavior:

  1. On WP Admin > Settings, set the Site Language to a language other than English like PT BR - Português do Brasil
  2. Make sure to download any translation updates under My Home > Updates
  3. Create a page, add the All Products block to it, and save it
  4. View the page from the front end

Expected behavior

"Sale" should be translated on the front end.

Screenshots

Translated “Sale” on the All Products Block while Editing the Page:
Translated Sale on the All Products Block while Editing the Page

Untranslated “Sale” on the All Products Block from the Front End:
Untranslated Sale on the All Products Block from the Front End

Translated “Sale” on the Hand-picked Products Block from the Front End:
Translated Sale on the Hand-picked Products Block from the Front End

Translated “Sale” on the On Sale Products Block from the Front End:
Translated Sale on the On Sale Products Block from the Front End

Environment

WordPress:

  • Core version: 5.7
  • Gutenberg version: 10.2.1
  • WooCommerce version: 5.1.0
  • WooCommerce Blocks version: 4.4.3
  • Site language: en_US
  • Any other plugins installed:
    • Akismet Anti-Spam: by Automattic – 4.1.9
    • AMP: by AMP Project Contributors – 2.0.11
    • CoBlocks: by GoDaddy – 2.9.1
    • Crowdsignal Forms: by Automattic – 1.4.5
    • WordPress.com Editing Toolkit: by Automattic – 3.3396
    • Jetpack by WordPress.com: by Automattic – 9.5.2
    • Layout Grid: by Automattic – 1.5
    • Page Optimize: by Automattic – 0.5.1

Desktop:

  • OS: macOS
  • Browser: Chrome

Additional context

@igotdes igotdes added the type: bug The issue/PR concerns a confirmed bug. label Mar 31, 2021
@nerrad nerrad added focus: i18n The issue/PR is related to internationalization. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Mar 31, 2021
@mikejolley mikejolley self-assigned this Jun 23, 2021
@nerrad nerrad reopened this Oct 20, 2021
@nerrad nerrad closed this as completed Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: i18n The issue/PR is related to internationalization. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
3 participants