Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Abstract Payments/API class to be used by other plugins #3532

Closed
senadir opened this issue Dec 9, 2020 · 2 comments · Fixed by #3829
Closed

Abstract Payments/API class to be used by other plugins #3532

senadir opened this issue Dec 9, 2020 · 2 comments · Fixed by #3829
Assignees
@mikejolley
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement.

Comments

@senadir
Copy link
Member

senadir commented Dec 9, 2020

Based on the discussion in https://github.com/woocommerce/woocommerce-subscriptions/pull/3906#discussion_r537126352 we want to:

abstract some of the current server side Payment API interface to wrap a new generic extension interface that is doing much of what the Payment API interface is doing now.

The new interface should allow extensions to:

  • Load data via wcSettings and AssetDataRegistry.
  • enqueue styles and scripts for Cart and Checkout.

Some of the core functionality of this file src/Payments/Api.php should be moved to that abstract class.
@senadir senadir added type: enhancement The issue is a request for an enhancement. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. labels Dec 9, 2020
@senadir
Copy link
Member Author

senadir commented Dec 9, 2020

cc @nerrad and @opr

@nerrad nerrad added block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Dec 10, 2020
@senadir senadir mentioned this issue Dec 29, 2020
Closed
15 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 9, 2021
@nerrad nerrad added type: cooldown Things that are queued for a cooldown period (assists with planning). and removed status: stale Stale issues and PRs have had no updates for 60 days. labels Feb 9, 2021
@mikejolley mikejolley self-assigned this Feb 9, 2021
@mikejolley mikejolley mentioned this issue Feb 11, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
3 participants
@mikejolley @nerrad @senadir