Spilled icecream (js error) with Filter Products by Attribute when store has no attributes

[haszari]

To reproduce

• Ensure your store has no product attributes set up.
• Add a Filter Products by Attribute block to a page or post, publish.
• View on front end - javascript error: TypeError: Cannot read property 'id' of undefined

We probably need some checks to render nothing / placeholder if the store has no attributes.

[nerrad]

@haszari I've moved this to the backlog for now. However, if you can't reproduce on a released version of the blocks (or WC core), then note that in the issue and I'll consider giving it a higher priority.

[haszari]

Confirming this is reproducible on WordPress 5.4.1 (current) with current WooCommerce and WooCommerce Blocks:

It's a bit of an edge case I guess.

[nerrad]

It's a bit of an edge case I guess.

It's an edgecase, but would still be nice to give some feedback to merchants when they are configuring the filter block in the backend to that they have fair warning they need to setup some attributes before using the block.

With that said, since this has been out in the wild for a while now (thanks for verifying ✋) and there doesn't seem to be mention of it surfacing anywhere, I think we can leave it in the backlog and pick it up as a cooldown task at some point.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

[github-actions]

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

[dinhtungdu]

There is another error in the editor that relates to this issue: Adding Filter Products by Attribute then clicking Save without selecting any attribute causes the block to fail to preview: