Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Single Product Atomic Inner Blocks #2393

Closed
mikejolley opened this issue May 4, 2020 · 7 comments
Closed

Single Product Atomic Inner Blocks #2393

mikejolley opened this issue May 4, 2020 · 7 comments
Labels
focus: components Work that introduces new or updates existing components. type: enhancement The issue is a request for an enhancement. type: epic A label used by Zenhub for indicating issues functioning as an Epic.

Comments

@mikejolley
Copy link
Member

mikejolley commented May 4, 2020

The single product block requires additional atomic blocks and components to show product data and the full add to cart form experience.

@mikejolley mikejolley added the type: enhancement The issue is a request for an enhancement. label May 4, 2020
@garymurray
Copy link

Product description/short description. The current mocks appear to show a short description. We need to decide how full descriptions are rendered. "additional information" is out of scope for i1, however, description is mentioned. So this needs clarification from @garymurray

The intent was that this would use what has been set as the Product short description.

The designs are missing such as "in stock" text. Does this need revision?

Can you provide a list of what core currently shows there so we can decide how much of that we can/should show? I do believe for instance 'In stock` is something we would want to show.

@mikejolley
Copy link
Member Author

Can you provide a list of what core currently shows there so we can decide how much of that we can/should show? I do believe for instance 'In stock` is something we would want to show.

Wasn't this explored by design team already?

  • Sale badge
  • Product title
  • Product price (for variable products this is a range)
  • Stock text i.e. "In Stock" or "X left in stock"
  • Cart qty/button
  • SKU
  • Terms list (categories and tags)
  • Main image
  • Image gallery
  • Then the full description/attributes/reviews section
  • Then related products and upsells

@garymurray
Copy link

Thanks for those. @LevinMedia this should be able to inform any design work on the single block.

Wasn't this explored by design team already?

TBH, I am not sure - I had assumed most of this had been taken into account for already in the designs that had been worked on - but now that we taking a closer look at the designs it seems lots might have just been overlooked.

@LevinMedia
Copy link
Contributor

@mikejolley @garymurray

the scope from #2379 looks correct, I have a few comments to add:

Product description/short description. The current mocks appear to show a short description. We need to decide how full descriptions are rendered. "additional information" is out of scope for i1, however, description is mentioned.

This should use the short description - the full description is out of scope, and would be built into another block that would be part of a larger product page template, along with reviews etc)

Core feature parity - The designs are missing such as "in stock" text. Does this need revision?

I think this was overlooked, as I never saw mention of it in the original posts. If it's not too much extra scope, I think it would be nice to have. Likewise, the products SKU, categories and tags would be nice to haves as well. I'm not sure why they weren't included in the original scope.

If we're able to include all of the above, the only thing we'd be missing for full feature parity with core is gallery controls.

@LevinMedia
Copy link
Contributor

@mikejolley FWIW... I think we should also allow columns as an inner block for this thing, but maybe limiting its options to only 2 columns as a start.

@mikejolley mikejolley changed the title [Single Product Block] Create Atomic Components Single Product Block Atomic Blocks and Components May 20, 2020
@mikejolley mikejolley added focus: components Work that introduces new or updates existing components. type: epic A label used by Zenhub for indicating issues functioning as an Epic. labels May 20, 2020
@mikejolley mikejolley changed the title Single Product Block Atomic Blocks and Components Single Product Atomic Inner Blocks May 20, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@senadir senadir removed their assignment May 11, 2021
@Aljullu
Copy link
Contributor

Aljullu commented Apr 5, 2023

Closing this issue given that we are working on a new version of the Single Product block: #8054. Feel free to reopen if you think that's a mistake. 🙏

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Work that introduces new or updates existing components. type: enhancement The issue is a request for an enhancement. type: epic A label used by Zenhub for indicating issues functioning as an Epic.
Projects
None yet
Development

No branches or pull requests

6 participants