Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

TT4: Minor issues in pattern "Essential Header Dark" #11297

Closed
imanish003 opened this issue Oct 18, 2023 · 1 comment · Fixed by #11480
Closed

TT4: Minor issues in pattern "Essential Header Dark" #11297

imanish003 opened this issue Oct 18, 2023 · 1 comment · Fixed by #11480
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug.

Comments

@imanish003
Copy link
Contributor

Describe the bug

In Pattern "Essential Header Dark," there are design inconsistencies both on the Editor side and the Frontend side, particularly in terms of contrast and spacing.

To reproduce

Editor Side:

  1. Insert the "Essential Header Dark" Pattern.
  2. Notice the contrast issues with the search button when using the TT4 theme.
  3. Observe that there is no space between the "Shop" text and the user icon.

Before
image

Current
image

Frontend Side:

  1. Preview or publish the page containing the "Essential Header Dark" Pattern.
  2. Notice the contrast issues with the search icon.

Before
image

Current
image

Expected behavior

Editor Side:

  • The search button should have proper contrast to be easily accessible.
  • There should be adequate spacing between the "Shop" text and the user icon. All items after the "Shop" text should be aligned to the right corner for better design consistency.

Frontend Side:

  • The search icon should have good contrast against its background for better visibility.
@imanish003 imanish003 added type: bug The issue/PR concerns a confirmed bug. ▫️ pattern: headers labels Oct 18, 2023
@danieldudzic
Copy link
Contributor

I personally don't see a big issue with the search button color, but I understand your concern.

I have discovered a significant issue with lack of contrast on the dropdown menus in this pattern:

Essential_Header_Dark_–_Dominant_Penguin

@nerrad nerrad added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants