Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Customize your Store > Add margin right to the Hero Product 3 Split pattern #11254

Closed
Tracked by #11086
nefeline opened this issue Oct 15, 2023 · 2 comments
Closed
Tracked by #11086
Assignees
Labels
focus: patterns WooCommerce patterns type: bug The issue/PR concerns a confirmed bug.

Comments

@nefeline
Copy link
Contributor

nefeline commented Oct 15, 2023

Based on the feedback received from @verofasulo on Mrk6SERPZ4KrFHSjM0a8TK-fi-6359_47036 , update the Hero Product 3 Split pattern to include a margin to the right:

Screenshot 2023-10-16 at 01 39 52

@verofasulo would you please inform us of the desired margin in this particular case?

PS: it's worth mentioning that this difference in margin is not easily detectable when using the pattern within a regular post or template as those already have a default spacing that doesn't exist in the Assembler.

@nefeline nefeline transferred this issue from woocommerce/woocommerce Oct 15, 2023
@nefeline nefeline added focus: patterns WooCommerce patterns type: bug The issue/PR concerns a confirmed bug. and removed status: awaiting triage labels Oct 15, 2023
@albarin
Copy link
Contributor

albarin commented Oct 16, 2023

Hey @verofasulo, this fix was included in this PR #11206.
This is how it looks:
Screenshot 2023-10-16 at 13 46 33
Is that ok? Should we close this issue?

@albarin albarin self-assigned this Oct 16, 2023
@verofasulo
Copy link

Thanks, @albarin! It looks good.

That's the way it looked like when I went through the assembler on Friday last week:

image

If we've already fixed it, we can close the issue :)

@albarin albarin closed this as completed Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: patterns WooCommerce patterns type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

3 participants