Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Store Customization > Product Collection 5 Columns pattern: ensure the product title is a regular paragraph instead #11186

Closed
Tracked by #11086
nefeline opened this issue Oct 9, 2023 · 7 comments · Fixed by #11205
Assignees
Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.

Comments

@nefeline
Copy link
Contributor

nefeline commented Oct 9, 2023

Update the Product Collection 5 Columns pattern to ensure the product title is a paragraph instead of a heading:

Screenshot 2023-10-09 at 17 05 48

This change is required to ensure the fonts used for bot the product title and price are the same within the Pattern Assembler.

@nefeline nefeline added focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement. labels Oct 9, 2023
@tjcafferkey tjcafferkey self-assigned this Oct 10, 2023
@tjcafferkey
Copy link
Contributor

@nefeline there was talk in Fridays meeting about grouping the product title & price blocks into rows rather than columns to fix the design with long title names. Was a decision made on this? If it is a yes then I can do both changes in the same PR. Thanks!

@nefeline
Copy link
Contributor Author

there was talk in Fridays meeting about grouping the product title & price blocks into rows rather than columns to fix the design with long title names. Was a decision made on this? If it is a yes then I can do both changes in the same PR.

I believe we agreed on using short names for the Product titles instead (there's a task for this as the outcome of that discussion to define a character limit for the product title), but TBH I think having them displayed one per line might be better as it works well for all lengths of product titles: it would be good to confirm with @verofasulo if we can proceed with this approach.

@verofasulo
Copy link

but TBH I think having them displayed one per line might be better as it works well for all lengths of product titles

@nefeline @tjcafferkey, if we can tweak the pattern directly and wrap the price line, it's even better! However, I would still implement a character limit since AI-generated content might be unpredictable 😊

@tjcafferkey
Copy link
Contributor

I don't think its easily feasible to change this block from a Heading block to a Paragraph block:

In the Product Collections block the product title is a variation of the core/post-title block, which is a Heading block. Having spoken to @kmanijak he said the following:

I’m pretty sure paragraph cannot be used as a title. It won’t have required context to get post/product title. Personally I’d avoid allowing a paragraph becoming a title. It’s against semantics of this block and simply introduce another layer of complexity around already complex post title case

Another option would be to look into changing the product price block to become a Heading block so that they're at least consistent but again, I'm not sure how feasible this would be as an option.

@nefeline
Copy link
Contributor Author

nefeline commented Oct 10, 2023

I don't think its easily feasible to change this block from a Heading block to a Paragraph block:

In the Product Collections block the product title is a variation of the core/post-title block, which is a Heading block. Having spoken to @kmanijak he said the following:

Just to ensure we are all on the same page, this issue is for updating the content on the pattern level, not on the block level: on the pattern level, we have more freedom to adjust the formats to our needs.

We discussed this on Slack, but porting over my comment over here as well:

Maybe an approach we can investigate is if one of the heading styles is coincident with the paragraph styles so the font type matches.

@verofasulo
Copy link

I'm getting a bit confused 😅

I don't think its easily feasible to change this block from a Heading block to a Paragraph block:

Why does wrapping the price and having 1 line for the product name and 1 line for the price mean changing the block from a heading block to a paragraph block? Am I missing something? Thank you 🙏

@tjcafferkey
Copy link
Contributor

Why does wrapping the price and having 1 line for the product name and 1 line for the price mean changing the block from a heading block to a paragraph block? Am I missing something? Thank you

Sorry @verofasulo, so the problem here is that because the product price is a Paragraph block, and the product title is a Heading block it means that when you cycle through selecting different font pairings, the title can take one font, and the paragraph will take the other one. Meaning they're not consistent, although it might become more obvious depending on what font pairing you select.

It was discussed on a call to make the product title a Paragraph block so that they're consistent but as described above it might not be possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.
Projects
None yet
3 participants