Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Use the <header> element for the checkout header #10558

Closed
carolinan opened this issue Aug 12, 2023 · 5 comments · Fixed by #11222
Closed

Use the <header> element for the checkout header #10558

carolinan opened this issue Aug 12, 2023 · 5 comments · Fixed by #11222
Assignees
Labels
type: community contribution type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Milestone

Comments

@carolinan
Copy link

carolinan commented Aug 12, 2023

Describe the bug

The checkout template uses the checkout header template part, but it is set to use <div>, please consider using <header>.
Compare this with the cart and order information templates that use <header> for the standard header template part.

https://github.com/woocommerce/woocommerce-blocks/blob/trunk/templates/templates/checkout.html#L1
https://github.com/woocommerce/woocommerce-blocks/blob/trunk/templates/templates/cart.html#L1

To reproduce

Steps to reproduce the behavior:

  1. Open the checkout template in the Site Editor and select the checkout header template part, open the Advanced panel, and confirm that it uses a div not header.

Expected behavior

I expect the header to use the header element.

Screenshots

The header template part in the checkout template, with div pre-selected in the HTML element option:

Environment

WordPress (please complete the following information):

  • WordPress version: 6.3.0
  • WooCommerce version: 8.x

Additional context

Kindly go through the remaining templates and confirm that they too, are as accessible as possible.

Related:
#10557

@carolinan carolinan added the type: bug The issue/PR concerns a confirmed bug. label Aug 12, 2023
@wavvves wavvves added type: enhancement The issue is a request for an enhancement. and removed type: bug The issue/PR concerns a confirmed bug. labels Aug 15, 2023
@ralucaStan ralucaStan added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Aug 28, 2023
@ralucaStan
Copy link
Contributor

Thank you @carolinan, we will soon work on this change.
We'd also appreciate help from contributors who want to give a helping hand by working on a quick win task.

@wavvves wavvves added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Sep 13, 2023
@wavvves
Copy link
Contributor

wavvves commented Sep 13, 2023

temporarily blocked by #10773

@wavvves wavvves removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Oct 9, 2023
@danieldudzic danieldudzic reopened this Oct 24, 2023
@danieldudzic danieldudzic added this to the 11.5.0 milestone Oct 24, 2023
@mikejolley
Copy link
Member

The fix in #11222 did not work with the default templates despite being set to <header> in the editor. Moving to the current sprint to be worked on again.

@danieldudzic
Copy link
Contributor

#11222 has been removed from the 11.4.0 release.

@mikejolley mikejolley self-assigned this Nov 1, 2023
@mikejolley
Copy link
Member

#11222 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: community contribution type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants