Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Store Customization > Design feedback on wireframed and new patterns #10458

Closed
6 tasks done
Tracked by #10087
nefeline opened this issue Aug 3, 2023 · 3 comments
Closed
6 tasks done
Tracked by #10087

Store Customization > Design feedback on wireframed and new patterns #10458

nefeline opened this issue Aug 3, 2023 · 3 comments
Assignees
Labels
focus: patterns WooCommerce patterns

Comments

@nefeline
Copy link
Contributor

nefeline commented Aug 3, 2023

This is an issue for us to capture any feedback from the design team for the wireframed and new patterns in the Store Customization MVP project #10087

Tasks

Preview Give feedback
  1. focus: patterns
    nefeline
  2. focus: patterns type: enhancement
    nefeline
  3. focus: global styles focus: patterns
    danielwrobert
  4. focus: patterns type: enhancement
    nefeline
  5. nefeline
  6. focus: patterns
    nefeline
@nefeline nefeline added the focus: patterns WooCommerce patterns label Aug 3, 2023
@nefeline nefeline changed the title Store Customization > Address design feedback on wireframed and new patterns Store Customization > Design feedback on wireframed and new patterns Aug 3, 2023
@jarekmorawski
Copy link

Regarding left and right paddings, I experimented with a few different options. I went with 64 px on desktop and 32 px on mobile. However, I think they should always follow whatever is set under Global Styles > Layout.

image

For WooX starting templates, we'd default to 64/32 px and let the user change it in the site editor later. All patterns should automatically adjust and scale. Is that feasible?

@nefeline
Copy link
Contributor Author

Hi there @jarekmorawski ! Taking the Testimonials Single Pattern as an example #10600 , regarding:

I think they should always follow whatever is set under Global Styles > Layout.

I've changed the layout type for the column with the content to constrained, so the inner block now uses the content width and can be inherited.

I went with 64 px on desktop and 32 px on mobile.

For WooX starting templates, we'd default to 64/32 px

Unfortunately, setting different paddings for mobile x desktop view is not possible, so I kept it as 32px across the board: let me know if that works!

@nefeline
Copy link
Contributor Author

nefeline commented Sep 5, 2023

We have finished addressing all design feedback, so I'm going ahead and closing out this issue 👍 .

@nefeline nefeline closed this as completed Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: patterns WooCommerce patterns
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants