Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Collection block: "No results" msg not displayed #10082

Closed
Marc-pi opened this issue Jul 3, 2023 · 5 comments
Closed

Product Collection block: "No results" msg not displayed #10082

Marc-pi opened this issue Jul 3, 2023 · 5 comments
Labels
block: product collection Issues related to the Product Collection block block-type: product-query Issues related to/affecting all product-query variations. type: bug The issue/PR concerns a confirmed bug. type: community contribution

Comments

@Marc-pi
Copy link

Marc-pi commented Jul 3, 2023

Describe the bug

The "No result found" is not displayed on front side, only on backoffice
Ping @albarin

To reproduce

Add the Production Collection block within a Page.

Expected behavior

  • The default message "No results found." (when no products are set yet in Woo) is displayed on editor side (admin)
    • but not on front side (end user side).
  • Should we replace the Product Beta blocks by the new Product Collection Block ???

Screenshots

  • front Editor side
    image

  • On front
    image

Environment

WooCommerce 7.8.1
Woo Blocks 10.5.0
WP 6.2.2.
Gutenberg 16.1.0

@Marc-pi Marc-pi added the type: bug The issue/PR concerns a confirmed bug. label Jul 3, 2023
@Marc-pi Marc-pi changed the title Production Collection > Newest arrivals > default msg don't displayed on front Product Collection > Newest arrivals > default msg don't displayed on front Jul 3, 2023
@thealexandrelara
Copy link
Contributor

Hi there @Marc-pi, thank you for reporting this issue! I confirm that I can reproduce this issue on my end as well!

The Product Collection block is currently experimental and its development is still in progress. If you'd like to check the progress, you can visit the Epic for this block)

At the moment, I would not recommend replacing the Products (Beta) block with the Product Collection block. I'm not sure if @kmanijak or @imanish003 have a different opinion on this matter.

@Marc-pi Marc-pi changed the title Product Collection > Newest arrivals > default msg don't displayed on front Product Collection > Newest arrivals > default msg not displayed on front Jul 6, 2023
@imanish003
Copy link
Contributor

imanish003 commented Jul 6, 2023

Hi @thealexandrelara, 👋

From the provided screenshot, it seems @Marc-pi is discussing an issue with the Products beta block. If I understand correctly, @Marc-pi is encountering this problem with the Products beta block and is considering whether we should substitute this block with the newer Product Collection block. @Marc-pi, please feel free to correct me if my interpretation isn't accurate.

However, it's important to note that I've also been able to reproduce this problem with both the Products beta and Product Collection blocks, implying we will need to fix this in both.

Regarding the Product Collection block, as @thealexandrelara has noted, it is currently experimental and not yet suitable for general usage. It's only visible in our development build. However, rest assured that we're making progress and planning to launch its beta version shortly. CC: @kmanijak

@imanish003 imanish003 added block-type: product-query Issues related to/affecting all product-query variations. block: product collection Issues related to the Product Collection block labels Jul 6, 2023
@kmanijak
Copy link
Contributor

kmanijak commented Jul 6, 2023

Hi, my colleagues provided great responses and addressed my observations.

I'd like to only add that both Products (Beta) and Product Collection work correctly in terms of the lack of products. These blocks have an inner block placeholder called "No Results":

image

where you can put any content you'd like to be displayed on the frontend in case there are no products available. If that placeholder is empty no content will be displayed, which is exactly what you experienced. In the example below I added a paragraph displaying there's no content:

Editor Frontend
image image

@Marc-pi, please let me know if that answers your concern.

However, I agree that block structure may be confusing and it may not be the best UX. If you have an idea how to improve this journey, please let us know! 🙌

@Marc-pi
Copy link
Author

Marc-pi commented Jul 6, 2023

yep, i suggest to add systematicaly in the pattern this fallout block, within the pattern group, to enhance pattern adoption.
what do you think about this ?

@manospsyx manospsyx changed the title Product Collection > Newest arrivals > default msg not displayed on front Product Collection block: "No results" msg not displayed Nov 28, 2023
@imanish003
Copy link
Contributor

Hi @Marc-pi,

In PR #11783, we've introduced a default UI for the 'No results' block in the Product Collection block, as illustrated in the screenshot below:

image

You're now able to swap out the “Products (Beta)” block for the “Product Collection (Beta)” to leverage this new default UI. I'll be closing this issue for now, but we're open to revisiting it if necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: product collection Issues related to the Product Collection block block-type: product-query Issues related to/affecting all product-query variations. type: bug The issue/PR concerns a confirmed bug. type: community contribution
Projects
None yet
Development

No branches or pull requests

4 participants