-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full screen merchant center set up screen/page #44
Comments
For the full-page architecture/dev setup, I'd take inspiration from http://wptest.local/wordpress/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard For the UX/UI, I was thinking of re-using the It could be stretched to 100%, with "< Get started with Google for eCommerce" acting as a "close" button, with |
It seems that the WP-admin's wizard is not quite re-usable yet, and very Profile specific. I'd try to come up with a more generic full-page wizard component, that could be used here and eventually there, to hopefully serve a consistent User- and Developer Experience. |
I think that is the best thing we have to take inspiration from 👍
Sounds great 🙇 just be conscious of balancing time investment in terms of making something that works for us to meet deadlines vs spending a lot of time architecting something to be super reusable. Based on our slack convos I've pushed up some example code for setting up some "pages" similar to the onboarding wizard https://github.com/woocommerce/google-listings-and-ads/tree/menus |
@tomalec ,
Do you mean putting the merchant center setup wizard into the Modal component? Personally I thought it's going to be a full page wizard like the "Welcome to WooCommmerce" setup wizard, not in a Modal. |
Good point thanks. I just came from Web Components world, where extracting full-page layout and behavior to a separate component, like <full-screen-wizard>
<h1 slot="header"><a>‹ Get started with Google for eCommerce</a></h1>
<a slot="corner-menu">Help</a>
<wp-stepper></wp-stepper>
<div>...steps...</div>
</full-screen-wizard> would be faster and easier. I hope, I'll learn the React content distribution and alternatives soon enough.
Thanks 👍 |
Fair point. The more I look into the setup wizard, the more I feel Modal was a bad idea. I was mostly thinking of the experience of a user that clicks "Get Started" button, and suddenly the WP chrome disappears. I thought modal-like transition, like an animation of a window asking over the screen, would be comforting. In a slack conversation, @j111q suggested that for such wizard screen, the menus could slide away to the top and left respectively. However, at this point, given, we do not have enough building blocks ready, and time pressing, such considerations and tweaks are overkill nice to haves. |
@tomalec ,
I share the same opinion with you that it looks jarring and not a good experience. Yeah, we can look into that in the future. |
That sounds amazing ❤️ 😍 but like you say @tomalec I don't believe we have enough building blocks or prior art within WordPress or Woo for that sort of thing atm. I think for now it's best to stick with the onboarding and WCPay approaches for now. |
Definitely not opposed to it, just wanted to provide some guidance if it's looking like something that would take a bunch of time 👍 |
@jconroy , want to double check with you, I guess it's fine to close this issue? Or is there anything else that we should keep this issue open? |
I think we're good to close this one |
Description:
Set up basic scaffolding for the merchant center set up screen/page
Upon clicking the "Get started" (or "Continue Setup") on the getting started page a full-page set up screen/page should be displayed
At the top left of the page will be a backlink with the text "< Get started with Google for eCommerce" - this will return the user to the getting started page
At the top right of the page will be a help link pointing to extension documentation (location to be confirmed).
The set up process will consist of 2 steps:
Each of these is essentially a tabbed content area (or equivalent approach).
Note - during development, we may need to fake some of this logic initially (or options etc.) to avoid being blocked - actual functionality can be added as it is finalised.
Screenshots
Step 1
Step 2
Technical
Acceptance criteria:
Dependencies
Out of bounds/rabbit holes
Event tracking:
The text was updated successfully, but these errors were encountered: