TopBar background color (corner bug)

[vicenterusso]

Bug report

There is a very thin border that Is bothering me on top bar

Scenario 1 (with corner bug)

Code

WoltModalSheetPage(
  hasSabGradient: false,
  forceMaxHeight: true,
  topBar: Container(
    color: infoBlue,
    child: // etc ...

Image: (check corners)

Scenario 2 (no corner bug)

Code

WoltModalSheetPage(
  hasSabGradient: false,
  forceMaxHeight: true,
  backgroundColor: infoBlue,
  topBar: Container(
    child: // etc ...

Image:

Expected behavior

I cannot use second code because the whole modal with have "infoBlue" color. I expect a smooth corner without any white glitches.

[ulusoyca]

Do you see difference if you set the clip behavior in the theme data to Clip.antiAliasWithSaveLayer in https://github.com/woltapp/wolt_modal_sheet/blob/main/lib/src/theme/wolt_modal_sheet_theme_data.dart#L32

antiAlias Vs antiAliasWithSaveLayer

[vicenterusso]

Yep, that fixes it. Why this is not the default value? Whats the usecase for Clip.antiAlias and not Clip.antiAliasWithSaveLayer?

[ulusoyca]

This is a valid question. The Flutter SDK defaults to Clip.none. I can't recall the reasoning but I think we can default to Clip.antiAliasWithSaveLayer. What do you think @TahaTesser?

[ulusoyca]

@vicenterusso Here is the PR: #164

[vicenterusso]

@vicenterusso Here is the PR: #164

Perfect!

[TahaTesser]

This is a valid question. The Flutter SDK defaults to Clip.none. I can't recall the reasoning but I think we can default to Clip.antiAliasWithSaveLayer. What do you think @TahaTesser?

It defaults to none as clipping is not necessary when you don't provide a shape, but in the package, if you're always providing a shape then you can definitely the change the default