-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InitSuites
changes to order making BUILD_TLS_AES_256_GCM_SHA384
be prioritized over BUILD_TLS_AES_128_GCM_SHA256
#7771
InitSuites
changes to order making BUILD_TLS_AES_256_GCM_SHA384
be prioritized over BUILD_TLS_AES_128_GCM_SHA256
#7771
Conversation
…e prioritized over `BUILD_TLS_AES_128_GCM_SHA256`
…e prioritized over `BUILD_TLS_AES_128_GCM_SHA256` to match TLS 1.2.
…into InitSuites_Orderadj
Retest this please |
@aidangarske its just the python port that is failing now. it has a check expecting 32 and its now 48.
If you can fix in OSP repo and put up a PR and reference this we can merge it after we merge this one. NOTE: This PR could potentially cause issues for some customers, so we may need to add an option to support the old behavior. I'd also really like to get @SparkiDev to review this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the Python patch in OSP to support either 32 or 48 for now. Once that is pushed through we can merge this one
Retest this please. Python test should pass now. |
Retest this please. Generic config “ FAIL scripts/openssl.test ” |
Description
internal.c
-InitSuites
changes to order makingBUILD_TLS_AES_256_GCM_SHA384
be prioritized overBUILD_TLS_AES_128_GCM_SHA256
to match TLS 1.2 order.-fix for test
quic.c
,api.c
, andtest.h
hard coded size assumption.-fix
ssl.c
TRUE/FALSE to 1/0.Testing
Requires: wolfSSL/osp#213