Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitSuites changes to order making BUILD_TLS_AES_256_GCM_SHA384 be prioritized over BUILD_TLS_AES_128_GCM_SHA256 #7771

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

aidangarske
Copy link
Contributor

@aidangarske aidangarske commented Jul 19, 2024

Description

internal.c - InitSuites changes to order making BUILD_TLS_AES_256_GCM_SHA384 be prioritized over BUILD_TLS_AES_128_GCM_SHA256 to match TLS 1.2 order.
-fix for test quic.c, api.c, and test.h hard coded size assumption.
-fix ssl.c TRUE/FALSE to 1/0.

Testing

./configure --enable-all --enable-debug --disable-shared 
make
make check

Requires: wolfSSL/osp#213

aidan garske added 3 commits July 12, 2024 12:45
…e prioritized over `BUILD_TLS_AES_128_GCM_SHA256`
…e prioritized over `BUILD_TLS_AES_128_GCM_SHA256` to match TLS 1.2.
@aidangarske aidangarske self-assigned this Jul 19, 2024
@dgarske
Copy link
Contributor

dgarske commented Jul 19, 2024

Retest this please

@dgarske dgarske requested a review from SparkiDev July 24, 2024 20:14
tests/api.c Outdated Show resolved Hide resolved
@aidangarske aidangarske marked this pull request as draft August 9, 2024 20:20
@dgarske
Copy link
Contributor

dgarske commented Nov 18, 2024

@aidangarske its just the python port that is failing now. it has a check expecting 32 and its now 48.

======================================================================
FAIL: test_tls_unique_channel_binding (test.test_ssl.ThreadedTests)
Test tls-unique channel binding.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/workspace/PRB-python-port/osp/Python/Python-3.8.14/Lib/test/test_ssl.py", line 4204, in test_tls_unique_channel_binding
    self.assertEqual(len(cb_data), 32)
AssertionError: 48 != 32

----------------------------------------------------------------------

Ran 163 tests in 10.657s

FAILED (failures=1, skipped=18)
1 test failed again:
    test_ssl

If you can fix in OSP repo and put up a PR and reference this we can merge it after we merge this one.

NOTE: This PR could potentially cause issues for some customers, so we may need to add an option to support the old behavior. I'd also really like to get @SparkiDev to review this change.

@dgarske dgarske assigned SparkiDev and wolfSSL-Bot and unassigned aidangarske Nov 18, 2024
@dgarske dgarske marked this pull request as ready for review November 18, 2024 22:04
@dgarske dgarske self-assigned this Nov 18, 2024
@SparkiDev SparkiDev removed their assignment Nov 19, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Python patch in OSP to support either 32 or 48 for now. Once that is pushed through we can merge this one

@dgarske
Copy link
Contributor

dgarske commented Nov 22, 2024

Retest this please. Python test should pass now.

@dgarske
Copy link
Contributor

dgarske commented Nov 22, 2024

Retest this please. Generic config “ FAIL scripts/openssl.test ”

@dgarske dgarske assigned SparkiDev and unassigned dgarske and aidangarske Nov 22, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit 6dd00ab into wolfSSL:master Nov 22, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants