Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python cipher suite check #213

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Nov 22, 2024

Before:

FAIL: test_tls_unique_channel_binding (test.test_ssl.ThreadedTests)
Test tls-unique channel binding.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/davidgarske/GitHub/python-3.8.14/Lib/test/test_ssl.py", line 4206, in test_tls_unique_channel_binding
    self.assertEqual(len(cb_data), 48)
AssertionError: 32 != 48

----------------------------------------------------------------------

Ran 163 tests in 36.776s

FAILED (failures=1, skipped=17)
test test_ssl failed
1 test failed again:
    test_ssl

== Tests result: FAILURE then FAILURE ==

1 test failed:
    test_ssl

1 re-run test:
    test_ssl

Total duration: 1 min 13 sec
Tests result: FAILURE then FAILURE

After:

test_tls_unique_channel_binding (test.test_ssl.ThreadedTests)
Test tls-unique channel binding. ... 
 server:  new connection from ('127.0.0.1', 51813)
 got channel binding data: b'\x7f\xb1\xdcf\xf0\x0f\xc5\x82\n\x02\x8a\\L]\xf2\x87\x17[\xc6\x9d\xc5Q|\xc2TY\xd9\x13\xaf\xe7\xe1\xea'
 server: connection cipher is now ('TLS_AES_128_GCM_SHA256', 'TLSv1.3', 128)
 server: selected protocol is now None
 server:  new connection from ('127.0.0.1', 51814)
got another channel binding data: b'\\UY\xa7|1\x13:\x14\x9c\xbf\x9a\x98W\xaf\xa6\x01W\x07\x0bb\x88n4[x7\x06^3)\xd3'
 server: connection cipher is now ('TLS_AES_128_GCM_SHA256', 'TLSv1.3', 128)
 server: selected protocol is now None
ok
...

Ran 163 tests in 35.947s

OK (skipped=17)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 36.2 sec
Tests result: SUCCESS

Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants