You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the wheel filename does conform to PyPI's standard, file_to_package() would definitely need to be updated. If not , PyQt5 maintainers would surely need to improve their packaging practice, but file_to_package() may also benefit from some kind of change that protects against this error. (I do not know whether this preventive change would be feasible, but I hope so.)
EDIT: on a second thought, perhaps we can simply remove the elif file_ext == ".whl": case and leave it to be handled by the final else: case in file_to_package()?
The text was updated successfully, but these errors were encountered:
The bits = file.rsplit("-", 4) means that the leftmost split never happens and the version number ends up in the folder name (triton-2-0-0) in the resulting /simple folder.
This means that where the package is a dependency of another package pip fails to find it.
As suggested above, commenting out the '.whl' logic and leaving it the regex in the else clause seems to do the trick. Not sure how to modify the tests to cover build tags and be sure though.
For instance, with the following file from PyQt5, we have:
If the wheel filename does conform to PyPI's standard,
file_to_package()
would definitely need to be updated. If not , PyQt5 maintainers would surely need to improve their packaging practice, butfile_to_package()
may also benefit from some kind of change that protects against this error. (I do not know whether this preventive change would be feasible, but I hope so.)EDIT: on a second thought, perhaps we can simply remove the
elif file_ext == ".whl":
case and leave it to be handled by the finalelse:
case infile_to_package()
?The text was updated successfully, but these errors were encountered: