Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special fonts are not rendered correctly #62

Closed
xiaoyangzi opened this issue Sep 19, 2017 · 8 comments
Closed

Special fonts are not rendered correctly #62

xiaoyangzi opened this issue Sep 19, 2017 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xiaoyangzi
Copy link

several pdf files is unreadable when rendered:
unreadable
here is the file should be:
readable

@wojtekmaj
Copy link
Owner

Hey @xiaoyangzi,
thanks for reporting. This is an issue with PDF.js, an engine React-PDF uses to render PDFs (Mozilla Firefox is also using it).
Please report it to mozilla/pdf.js giving them examples of files that render incorrectly.
Thank you in advance,
Wojciech

@wojtekmaj wojtekmaj added the invalid This doesn't seem right label Sep 19, 2017
@xiaoyangzi
Copy link
Author

This file is rendered correctly by the online viewer Mozilla/pdf.js provide. Maybe it's a version problem that pdf-dist is not sync the pdf.js lateast version I think.

@wojtekmaj
Copy link
Owner

I'll have a look then. Could you please kindly attach the file you have a problem with?

@wojtekmaj wojtekmaj reopened this Sep 20, 2017
@wojtekmaj wojtekmaj removed the invalid This doesn't seem right label Sep 20, 2017
@xiaoyangzi
Copy link
Author

23.pdf

@wojtekmaj
Copy link
Owner

wojtekmaj commented Sep 20, 2017

Thank you. I already kinda know what's up, I'm just not entirely sure how to fix it. Asked for some assistance from Mozilla @ mozilla/pdf.js#8937
Will get back to you if I come up with a solution.

@wojtekmaj wojtekmaj changed the title pdf content is unreadable Special fonts are not rendered correctly Sep 20, 2017
@wojtekmaj wojtekmaj added the bug Something isn't working label Sep 20, 2017
@wojtekmaj wojtekmaj self-assigned this Sep 20, 2017
@wojtekmaj wojtekmaj added this to the 2.2.0 milestone Sep 26, 2017
@wojtekmaj
Copy link
Owner

wojtekmaj commented Sep 28, 2017

Hey @xiaoyangzi!
The issue is a little complicated.

First of all: Some PDF files with exotic characters/fonts may require helper files called cMaps. Mozilla is currently fixing an issue where these cMaps are requested from a null location.

Once they do fix this, I can come and do some enhancements in the code to make it possible to set cMap file location.

Fixing this issue will take some time and will also require you to write some code and configuration once I come up with the solution.

@KiaFathi
Copy link

KiaFathi commented Nov 1, 2017

+1 request for cMap support. Would a similar workaround to mikecousins/react-pdf-js#16 be possible in this library as well?

@wojtekmaj wojtekmaj added question Further information is requested and removed bug Something isn't working labels Nov 16, 2017
@wojtekmaj
Copy link
Owner

wojtekmaj commented Nov 17, 2017

Hey @xiaoyangzi and @KiaFathi, good news!

Check out Support for non-latin characters that just landed in v2.3.0!

I'm super curious what you think about it. Tell me your comments and suggestions for improvements if any!

@wojtekmaj wojtekmaj added bug Something isn't working and removed question Further information is requested labels Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants