Fix SMTP AUTH LOGIN method for servers with uncommon success messages #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #94 and basically reverts d0f0435. As James points out correctly in #94, we should not assume specific responses from the server. As long as the spec is followed and the server returns the correct SMTP code, we should not do our own magic. I've also extended the `getTestConnection` method in client_test.go, so that we can specify more test environment options like `TEST_PORT` and `TEST_TLS_SKIP_VERIFY`. This was needed for testing with the ProtonMail Bridge which listens on a different port and has non-trusted certificates.
Removed "2.7.0 Authentication successful" challenge since this should never be sent with `more == true`.
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 83.15% 83.07% -0.08%
==========================================
Files 15 15
Lines 1549 1548 -1
==========================================
- Hits 1288 1286 -2
- Misses 186 187 +1
Partials 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wneessen
deleted the
94-login-auth-next-handler-should-unconditionally-succeed-if-more-is-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #94 and basically reverts d0f0435. As James points out correctly in #94, we should not assume specific responses from the server. As long as the spec is followed and the server returns the correct SMTP code, we should not do our own magic.
I've also extended the
getTestConnectionmethod in client_test.go, so that we can specify more test environment options likeTEST_PORTandTEST_TLS_SKIP_VERIFY. This was needed for testing with the ProtonMail Bridge which listens on a different port and has non-trusted certificates.