Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a couple more issues and I hope this PR will fix them.
sendmail
still "hangs", because Stderr is read before Stdin was closed, should be reversed.io.Reader
'sRead
method does not read into nil slice, according to documentation it will read up tolen(p)
wherep
is byte slice.Close
, plus according to documentation both Stderr and Stdin pipes will be closed automatically whenWait
sees program exit.