Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #29: Allow attaching/embedding from embed.FS #30

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

wneessen
Copy link
Owner

@wneessen wneessen commented Jul 7, 2022

  • Added EmbedFromEmbedFS() to allow embedding from embed.FS
  • Added AttachFromEmbedFS() to allow attaching from embed.FS
  • Added fileFromEmbedFS() as internal method for both other m
    methods to attach/embed the embed.FS file

- Added `EmbedFromEmbedFS()` to allow embedding from embed.FS
- Added `AttachFromEmbedFS()` to allow attaching from embed.FS
- Added `fileFromEmbedFS()` as internal method for both other m
  methods to attach/embed the embed.FS file
@codecov-commenter
Copy link

Codecov Report

Merging #30 (192627f) into main (4e4d3f5) will decrease coverage by 0.60%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   83.60%   82.99%   -0.61%     
==========================================
  Files          10       10              
  Lines        1055     1094      +39     
==========================================
+ Hits          882      908      +26     
- Misses        122      131       +9     
- Partials       51       55       +4     
Impacted Files Coverage Δ
msg.go 84.22% <66.66%> (-1.47%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wneessen wneessen merged commit db2d581 into main Jul 7, 2022
@wneessen wneessen deleted the 29-embedfs branch July 7, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants