Fork the net/smtp package from Go's stdlib into go-mail #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #97 we are going to fork the official `net/smtp` package into go-mail to provide us with more flexibility. This commit fulfills the first big step of importing the package into smtp/. Also go-mail's own LoginAuth has been moved from auth/ into smtp/ to be consistent with the stdlib. There are still a couple of open issues (i. e. license adjustments and making golangci-lint happy) but so far all tests already work, which is a good start.
- Also import the original BSD-3-Clause.txt license from the Go team into the LICENSES directory - Further on, license headers should hold "The go-mail Authors" instead of my name. Did this already for the MIT license.
Fixed open issues in smtp_test.go
Fix open TODO in smtp_test.go and fork `testenv.SkipFlaky()` from `internal/testenv` to implement flaky test skipping for FBSD
Implemented negative check for AuthLogin Auth method
…e Go project into the smtp/ directory as suggested in #97 (comment)
The following changes make use of methods that are not available in Go 1.17/Go 1.18. To guarantee at least 4 versions of backwards compatibility, versioned copies of those changes have been back-ported: - golang/go@4d8db00#diff-4f6f6bdb9891d4dd271f9f31430420a2e44018fe4ee539576faf458bebb3cee4 - golang/go@58158e9#diff-772fc9f5d0c86f26e35158fb3e7a71a4967d18b4ec23a5dbb60781ab0babf426
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 83.26% 80.89% -2.38%
==========================================
Files 15 20 +5
Lines 1548 1837 +289
==========================================
+ Hits 1289 1486 +197
- Misses 185 251 +66
- Partials 74 100 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wneessen
deleted the
feature/97_fork-the-netsmtp-package-from-stdlib-into-go-mail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #97 we are going to fork the official
net/smtppackage into go-mail to provide us with more flexibility.This PR forks
net/smtpbased on original Go stdlib commit: golang/go@b2faff1 intosmtp/. Also go-mail's ownLoginAuthhas been moved fromauth/intosmtp/to be consistent with the stdlib.The original license has been imported and the license headers have been adjusted to reflect the go-mail's MIT license and the original Go BSD-3-Clause license. Additionally, the license headers have been converted to SPDX style.
Finally the code and tests of the original code have been adjusted in a way that the complaints of golanci-lint were fixed.