Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp: AUTH LOGIN should follow ietf-draft more closely #311

Closed
wneessen opened this issue Oct 2, 2024 · 0 comments · Fixed by #312
Closed

smtp: AUTH LOGIN should follow ietf-draft more closely #311

wneessen opened this issue Oct 2, 2024 · 0 comments · Fixed by #312
Assignees
Labels
bug Something isn't working hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest WIP Work is in progress

Comments

@wneessen
Copy link
Owner

wneessen commented Oct 2, 2024

Description

During the discussion in https://github.com/mjl-/mox/issues/223 it was discovered that we are not following the SMTP AUTH LOGIN draft closely, but rather expecting a "MAY" implementation detail for servers.

The draft states for clients:

The contents of both challenges SHOULD be ignored.

For servers it recommends:

There is at least one widely deployed client which requires that the challenge strings transmitted by the server be "Username:" and "Password:" respectively. For this reason, server implementations MAY send these challenge strings instead of those listed above.

We are following the server recommendation and expected "Username:", "username:" or "User name\x00" (the same for passwords).

To Reproduce

Try "SMTPAuthLogin" with a server that does not send one of the expected responses. The client will fail authenticate.

Expected behaviour

The client should follow the I-D and ignore the server responses (or at least not fail if a different response is sent)

Screenshots

No response

Attempted Fixes

No response

Additional context

No response

@wneessen wneessen added the bug Something isn't working label Oct 2, 2024
@wneessen wneessen self-assigned this Oct 2, 2024
@wneessen wneessen added WIP Work is in progress hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest labels Oct 2, 2024
@wneessen wneessen linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest PRs are requested to be eligible to participate in Hacktoberfest hacktoberfest-accepted PR has been accepted to participate in Hacktoberfest WIP Work is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant